4a67437704
**Investigation:** - According to [here](https://github.com/microsoft/playwright/actions/runs/8351676198), the job got cancelled, because someone force-pushed and another commit took priority. - We have `if: always()` for uploading the blobs, even if they are cancelled. We expect, that the task before (`npx playwright test`) finished writing the blob, but it didn't - cancelled in between. We still upload - a broken one. - We download the broken zip and it breaks from there on. Proposed change: Instead of uploading always, upload if it did not get cancelled. Quoting from the GitHub Actions docs about `always()`: > Warning: Avoid using always for any task that could suffer from a critical failure, for example: getting sources, otherwise the workflow may hang until it times out. If you want to run a job or step regardless of its success or failure, use the recommended alternative: if: `${{ !cancelled() }}` This is phase 1/2 where it changes our code to use this new condition. The actual roll-out happens once it works for us. Relates https://github.com/microsoft/playwright/issues/29451
31 lines
1.1 KiB
YAML
31 lines
1.1 KiB
YAML
name: 'Upload blob report'
|
|
description: 'Upload blob report to GitHub artifacts (for pull requests)'
|
|
inputs:
|
|
report_dir:
|
|
description: 'Directory containing blob report'
|
|
required: true
|
|
default: 'test-results/blob-report'
|
|
job_name:
|
|
description: 'Unique job name'
|
|
required: true
|
|
default: ''
|
|
runs:
|
|
using: "composite"
|
|
steps:
|
|
- name: Upload blob report to GitHub
|
|
if: ${{ !cancelled() && github.event_name == 'pull_request' }}
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: blob-report-${{ inputs.job_name }}
|
|
path: ${{ inputs.report_dir }}/**
|
|
retention-days: 7
|
|
- name: Write triggering pull request number in a file
|
|
if: ${{ !cancelled() && github.event_name == 'pull_request' }}
|
|
shell: bash
|
|
run: echo '${{ github.event.number }}' > pull_request_number.txt;
|
|
- name: Upload artifact with the pull request number
|
|
if: ${{ !cancelled() && github.event_name == 'pull_request' }}
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: pull-request-${{ inputs.job_name }}
|
|
path: pull_request_number.txt |