playwright/packages
Max Schmitt e1e69cbbcc
fix(cli): pdf/screenshot did not save artifacts (#21352)
As of today we support CLI argument wise `--save-storage` and
`--save-har` in pdf/screenshot CLI command. But they are not working,
since we just close the browser rather than the context where we take
care of saving the artifacts.

`launchContext` has 4 usages:

- open/codegen there closing the browser / `SIGINT` will close it
gracefully
- pdf/screenshot there we will now close the page which will then
[here](b00579edb7/packages/playwright-core/src/cli/cli.ts?q=cli.ts#L503)
close the browser.

I did not find any tests except the [installation
test](3e84ab4701/tests/installation/playwright-cli-screenshot-should-work.spec.ts),
I'm happy to add one for both command if requested.

Fixes https://github.com/microsoft/playwright/issues/20718
2023-03-02 22:05:39 +01:00
..
html-reporter chore(trace): include expect steps in a trace (#21199) 2023-02-28 13:26:23 -08:00
playwright chore: mark 1.32.0-next (#20929) 2023-02-15 16:15:42 -08:00
playwright-chromium chore: mark 1.32.0-next (#20929) 2023-02-15 16:15:42 -08:00
playwright-core fix(cli): pdf/screenshot did not save artifacts (#21352) 2023-03-02 22:05:39 +01:00
playwright-ct-react chore: point to pwt cli, a direct dependency (#21311) 2023-03-01 12:17:43 -08:00
playwright-ct-solid chore: point to pwt cli, a direct dependency (#21311) 2023-03-01 12:17:43 -08:00
playwright-ct-svelte chore: point to pwt cli, a direct dependency (#21311) 2023-03-01 12:17:43 -08:00
playwright-ct-vue chore: point to pwt cli, a direct dependency (#21311) 2023-03-01 12:17:43 -08:00
playwright-ct-vue2 chore: point to pwt cli, a direct dependency (#21311) 2023-03-01 12:17:43 -08:00
playwright-firefox chore: mark 1.32.0-next (#20929) 2023-02-15 16:15:42 -08:00
playwright-test feat(typescript): allow declare for class properties (#21281) 2023-03-01 16:43:17 -08:00
playwright-webkit chore: mark 1.32.0-next (#20929) 2023-02-15 16:15:42 -08:00
protocol/src chore: migrate to protocol's StackFrame type (#21198) 2023-02-24 18:36:15 -08:00
recorder chore: implement pick locator in trace viewer (#20965) 2023-02-17 11:19:53 -08:00
trace/src chore: flatten metadata in trace events (#21214) 2023-02-27 15:29:20 -08:00
trace-viewer fix(trace): do not show duration tooltip for events (#21342) 2023-03-02 11:31:10 -08:00
web chore: ui mode first cut (#21291) 2023-03-01 15:27:23 -08:00
.eslintrc.js chore: don't write into stdout from the test runner, use reporters instead (#11367) 2022-01-12 19:52:40 -08:00