Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity
playwright/packages/playwright-core
History
Max Schmitt e1e69cbbcc
fix(cli): pdf/screenshot did not save artifacts (#21352) 
As of today we support CLI argument wise `--save-storage` and
`--save-har` in pdf/screenshot CLI command. But they are not working,
since we just close the browser rather than the context where we take
care of saving the artifacts.

`launchContext` has 4 usages:

- open/codegen there closing the browser / `SIGINT` will close it
gracefully
- pdf/screenshot there we will now close the page which will then
[here](b00579edb7/packages/playwright-core/src/cli/cli.ts?q=cli.ts#L503)
close the browser.

I did not find any tests except the [installation
test](3e84ab4701/tests/installation/playwright-cli-screenshot-should-work.spec.ts),
I'm happy to add one for both command if requested.

Fixes https://github.com/microsoft/playwright/issues/20718
2023-03-02 22:05:39 +01:00
..
bin chore(docker): remove experimental docker integration (#20676) 2023-02-06 10:50:45 -08:00
bundles chore: fix build/watch script for bundles and vite-powered packages (#20055) 2023-01-11 18:36:04 -08:00
src fix(cli): pdf/screenshot did not save artifacts (#21352) 2023-03-02 22:05:39 +01:00
types chore: mark waitForNavigation as deprecated consistently (#21309) 2023-03-01 12:40:50 -08:00
.npmignore chore: remove experimental dockerfile.remote (#20790) 2023-02-09 12:18:02 -08:00
browsers.json feat(firefox): roll to r1384 (#21271) 2023-03-01 10:25:43 +01:00
cli.js chore: migrate to monorepo (#9421) 2021-10-11 16:52:17 +02:00
index.d.ts chore: migrate to monorepo (#9421) 2021-10-11 16:52:17 +02:00
index.js chore: sunset Node.js 12 (#16512) 2022-08-15 18:10:04 +02:00
index.mjs fix: export request from index.jsm (#13158) 2022-03-30 09:35:47 -07:00
package.json chore: mark 1.32.0-next (#20929) 2023-02-15 16:15:42 -08:00
README.md chore: drop dependency on playwright-core in all our packages (#2318) 2020-05-21 13:18:15 -07:00
ThirdPartyNotices.txt chore: vendor proper-lockfile dependency (#19969) 2023-01-09 17:13:58 -08:00

README.md

playwright-core

This package contains the no-browser flavor of Playwright.