Filip/matrix-spec
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-spec synced 2025-12-23 09:38:38 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
4832 commits 30 branches 42 tags 32 MiB
Commit graph

707 commits

Author SHA1 Message Date
Andrew Morgan a8f4ada8a8 Make join_rules field of PublicRoomChunk an optional value 2021-03-24 16:49:57 +00:00
Andrew Morgan 9ebfd98a7a
Apply suggestions from code review 
Co-authored-by: Alexey Rusakov <Kitsune-Ral@users.sf.net>
 2021-03-24 16:33:47 +00:00
Andrew Morgan 10267df76e Add missing 403/404 response codes 2021-03-24 16:33:13 +00:00
Andrew Morgan 11996fb436 clarify some words 2021-03-24 16:20:19 +00:00
Andrew Morgan a1a40c6346 Be consistent about event auth rules 2021-03-23 18:17:47 +00:00
Andrew Morgan 7f0b2d66a0 Update unstable endpoints from i.e xyz.amorgan/knock -> xyz.amorgan.knock 
I'm doing this for two reasons:

1) If I ever wanted to create another knock-related MSC, it would be nice to be able
to give it a different namespace for endpoints, such as xyz.amorgan.knock2/knock. If
we were only using xyz.amorgan as the namespace for endpoints, that restricts that
namespace to only work for one MSC which attempts to use /knock as part of an endpoint.

2) I accidentally made the implementation use xyz.amorgan.knock/knock :)
 2021-03-23 12:23:42 +00:00
Andrew Morgan 68d2d7cfdb Note that homeservers should pass down invites to the client if they fail on autojoin 2021-03-09 17:16:25 +00:00
Andrew Morgan 8bfef19a39 Remove further traces of old /rooms/roomId/knock CS endpoint 2021-03-03 17:35:49 +00:00
Andrew Morgan ef840c1b53 Split the 'Membership change to ' section into rejecting/rescinding knocks 2021-03-03 17:33:26 +00:00
Andrew Morgan 6556b95233 Move API endpoint sections up to the top of the proposal 2021-03-03 17:25:17 +00:00
Andrew Morgan c915b6442b Update alternatives section 2021-03-03 17:13:29 +00:00
Andrew Morgan 09018be96c Link to existing spec documentation on the public rooms directory 2021-03-03 17:02:26 +00:00
Andrew Morgan 53ad7e3f66 Ensure we return the room_id after knocking via the CS API 2021-03-03 17:01:26 +00:00
Andrew Morgan c575f88d13 Move endpoint extras under endpoint's header 2021-03-03 16:53:17 +00:00
Andrew Morgan c9f34e818e Link to /join/roomIdOrAlias 2021-03-03 16:50:54 +00:00
Andrew Morgan 49a72862a9 Allow knock->knock transitions 2021-02-26 12:08:14 +00:00
Andrew Morgan e790ad2120
Apply suggestions from code review 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
 2021-02-24 18:45:11 +00:00
Andrew Morgan 24f61c283c Note that implementations may choose to auto-accept knock-related invites 2021-02-18 17:11:01 +00:00
Andrew Morgan eda65847a3 Comment on push rules 2021-02-18 17:07:31 +00:00
Andrew Morgan 248a3da5ca Switch /send_knock/ from v2 to v1; leave a note as to why 2021-02-18 16:49:03 +00:00
Andrew Morgan 74f3b12a17 Note experimental room version ID 2021-02-17 12:15:38 +00:00
Andrew Morgan 04cd6b3d3e
fix typo 
Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
 2021-02-17 12:13:44 +00:00
Andrew Morgan 337c87b949 Add 404 on make_knock if unknown room ID 2021-02-17 12:11:08 +00:00
Andrew Morgan 8400877574 Make ver a required parameter for make_knock 2021-02-17 11:02:21 +00:00
Andrew Morgan d5a2a284c5 Note clients should try to prevent impersonation attacks during knocking 2021-02-17 10:34:04 +00:00
Andrew Morgan 5c620de273 typo fix 2021-02-10 17:29:59 +00:00
Andrew Morgan 6a0d07c799 Public rooms directory backwards compatibility note 2021-02-09 11:18:55 +00:00
Andrew Morgan 51a7778217 typo 2021-02-08 18:38:38 +00:00
Andrew Morgan e99649cb84 Foreshadow power level requirements for approval/denial of knock 2021-02-08 18:37:08 +00:00
Andrew Morgan 42e01b8e91 Add join_rules to room chunks returned on a public room dir query 2021-02-02 19:50:41 +00:00
Andrew Morgan 7dcff8f2e1 Disallow invite->knock membership changes 2020-11-27 11:04:21 +00:00
Andrew Morgan 6c75b83b99 Address Travis and Patrick's feedback 2020-11-20 16:45:45 +00:00
Andrew Morgan 815dae6eae Note that redactions of knocks are not a concern 2020-10-08 18:04:32 +01:00
Andrew Morgan a924f5b3d5 Fix incorrect assumptions about the sender field of a knock event 
Got a bit confused with the sender and state_key being different in invite
membership events. In case of a knock, even if the knock event is being
inserted into the room by another homeserver over federation, the sender
of the event is still the knocking user, just like the state_key.
 2020-10-05 20:24:56 +01:00
Andrew Morgan 525d1d33e0 Some clarifications and wording fixes 2020-10-05 17:09:33 +01:00
Andrew Morgan 6f7bcb6052 Explicitly state what changes to the auth rules are necessary 2020-10-01 18:49:41 +01:00
Andrew Morgan 5097fad4e7 Fix unstable prefix bullet points 2020-10-01 17:43:49 +01:00
Andrew Morgan 6b99228386 Remove section duplicated by membership change section 2020-10-01 17:25:19 +01:00
Andrew Morgan fd8176b93d Clarify endpoint calls clients and servers need to use to handle knocks 2020-10-01 17:09:10 +01:00
Andrew Morgan 9e5ac042ac Explicitly state that the hs that received the knock must put in the room 2020-10-01 16:35:39 +01:00
Andrew Morgan e58e207bbf Go into more depth about membership changes surrounding knocking 2020-10-01 16:20:15 +01:00
Andrew Morgan 340f888de3 Mention unstable prefixes for sync, join_rules and membership events 2020-09-16 16:05:27 +01:00
Andrew Morgan 6e47e86f01 Add unstable endpoint replacements 2020-09-16 15:57:12 +01:00
Andrew Morgan fd9d57b8c4 Match state events sent to a remote server when inviting a user 2020-09-04 14:38:29 +01:00
Andrew Morgan 630f7c458c Allow users to knock over and over, removing CS complexity 2020-09-04 14:26:15 +01:00
Andrew Morgan 61fea58ce0 Merge branch 'soru/knock' of github.com:sorunome/matrix-doc into soru/knock 2020-09-03 16:08:46 +01:00
Andrew Morgan 703fa07028 Remove extraneous text 2020-09-03 16:07:16 +01:00
Andrew Morgan 58cb299dde
Update proposals/2403-knock.md 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
 2020-09-03 13:47:20 +01:00
Andrew Morgan c9a7b442ff Merge branch 'soru/knock' of github.com:sorunome/matrix-doc into soru/knock 
* 'soru/knock' of github.com:sorunome/matrix-doc:
  Federation knock_room_state and minor cleanup
 2020-09-02 23:15:26 +01:00
Andrew Morgan e93a19f62d Indicate that this proposal requires a new room version 2020-09-02 12:07:44 +01:00