Yury Semikhatsky
82fe882004
fix(webkit): scroll mobile page with background-attachment: fixed ( #33048 )
...
Fixes #31551
Fixes #23573
2024-10-10 14:32:27 -07:00
Playwright Service
7de084b6dc
feat(chromium-tip-of-tree): roll to r1268 ( #33042 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-10 16:32:00 +02:00
Playwright Service
217b57df4c
feat(webkit): roll to r2089 ( #33039 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-10 13:10:54 +02:00
Dmitry Gozman
25dd9b5cd4
feat: config.build.tsconfig ( #33026 )
...
Allows to specify `tsconfig` in the configuration file, which applies to
test files but not the config file itself.
Fixes #32808 .
2024-10-10 01:37:46 -07:00
Pavel Feldman
8f3353865d
fix(ui): bring back the headed param ( #33030 )
...
Fixes https://github.com/microsoft/playwright/issues/33023
2024-10-09 17:46:54 -07:00
Playwright Service
bc30cc795e
feat(chromium): roll to r1141 ( #33027 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-09 14:55:37 +02:00
Dmitry Gozman
c2cbf26497
docs: refresh timeouts doc ( #33025 )
...
After changes a few releases ago, specify that `afterEach` hooks are
included in a separate timeout.
Fixes #32851 .
2024-10-09 05:10:10 -07:00
Simon Knott
892d67ffef
feat(test runner): allow stopping testrun with escape ( #32584 )
...
Closes https://github.com/microsoft/playwright/issues/32579
2024-10-08 11:39:54 -07:00
Fumiaki MATSUSHIMA
5121b19ac6
fix(codegen): fix unselect issue ( #32127 )
...
Fixes https://github.com/microsoft/playwright/issues/31290
2024-10-08 11:38:52 -07:00
Pavel Feldman
6c9823eeaf
chore: allow minimal height for trace attachments ( #32996 )
2024-10-08 08:33:45 -07:00
Max Schmitt
d0f2170e21
Revert "fix(test): do not allow mixing tests from different types ( #29284 )" ( #33002 )
...
This reverts commit 4784139bb0https://github.com/microsoft/playwright/issues/29734
2024-10-08 16:00:40 +02:00
Simon Knott
042161e1ce
Reapply "fix(har timing): record connect timing for proxied connections" ( #32855 ) ( #33003 )
...
This reapplies what we reverted in
https://github.com/microsoft/playwright/pull/32989 .
Max and me debugged this, and found that the test failures come from
SOCKS proxy now preferring IPv6 over IPv4. We've updated the tests and
made sure that this doesn't mask any breaking change.
I'm enabling CQ1 to make sure we don't oversee any other CI failures.
2024-10-08 14:17:50 +02:00
Playwright Service
992994f036
feat(chromium-tip-of-tree): roll to r1267 ( #33007 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-08 14:13:45 +02:00
Dmitry Gozman
0f2cbdedac
fix(routeWebSocket): do not show in the trace ( #32991 )
2024-10-08 02:47:24 -07:00
Simon Knott
1b589c4bd3
Revert "fix(har timing): record connect timing for proxied connections" ( #32989 )
...
Reverts microsoft/playwright#32855 . This broke two tests on main, and we
don't yet know how to fix it other than downgrading.
2024-10-08 10:13:21 +02:00
Mark
04bf425268
feat(base-reporter): Add tags to test output ( #32930 )
2024-10-07 17:14:46 -07:00
Pavel Feldman
7047c3a6c6
fix(codegen): do not codegen non-existing fixtures ( #32993 )
...
Closes https://github.com/microsoft/playwright/issues/32981
2024-10-07 17:12:36 -07:00
Yury Semikhatsky
6ba5ee3a83
chore(ui-mode): expand all button ( #32994 )
...
<img width="230" alt="image"
src="https://github.com/user-attachments/assets/dd7fa3a1-39ec-4b88-9279-d664c9c4e5cd ">
Reference https://github.com/microsoft/playwright/issues/32825
2024-10-07 15:42:12 -07:00
Aaron Sherwood
4d13677ebd
chore: add Devuan OS fallback to Debian ( #32990 )
2024-10-07 23:24:18 +02:00
Yury Semikhatsky
4fe33db392
docs(route): header override propagation ( #32971 )
...
Fix https://github.com/microsoft/playwright/issues/32939
2024-10-07 13:52:55 -07:00
Simon Knott
9a6f03eb87
fix(fetch): listener leaks on Socket ( #32956 )
...
Closes https://github.com/microsoft/playwright/issues/32951
`node:http` reuses TCP Sockets under the hood. We weren't cleaning up
our listeners, leading to the `MaxListenersExceededWarning`.
This PR adds cleanup logic. It also raises the warning threshhold, so
that it doesn't trigger until there's 100 concurrent requests over the
same socket.
2024-10-07 18:43:25 +02:00
Simon Knott
d3fbf1aaeb
fix(clock): amend setSystemTime docs ( #32901 )
...
As discussed yesterday over
https://github.com/microsoft/playwright/issues/32807 . Adds some words to
differentiate `setSystemTime` from `setFixedTime`.
---------
Signed-off-by: Simon Knott <info@simonknott.de>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2024-10-07 12:12:12 +02:00
Simon Knott
de4a4d1ce1
fix(har timing): record connect timing for proxied connections ( #32855 )
...
Fixes a bug discovered in
https://github.com/microsoft/playwright/pull/32647 . When using http
proxy, the `connect` event isn't emitted so we don't populate
`tcpConnectionAt`. The updated version of `https-proxy-agent` emits a
`proxyConnect` as a replacement, so this PR updates and listens to that
event.
For socks proxies, the `on("socket")` event is emitted once the SOCKS
connection is established, which is the equivalent of having a TCP
connection available.
---------
Signed-off-by: Simon Knott <info@simonknott.de>
Co-authored-by: Max Schmitt <max@schmitt.mx>
2024-10-07 09:59:13 +02:00
Dmitry Gozman
9f842da8b3
fix: throw when element handle is detached while waiting for selector ( #32961 )
2024-10-04 08:23:25 -07:00
Simon Knott
40670e6ffd
fix(emulate media): document "no-preference" as deprecated ( #32881 )
...
Closes https://github.com/microsoft/playwright/issues/32862 .
`prefers-color-scheme: no-preference` was removed from browsers. This PR
marks it as deprecated in our docs and removes all mentions.
---------
Signed-off-by: Simon Knott <info@simonknott.de>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2024-10-04 16:49:32 +02:00
Dmitry Gozman
84b4fd4e40
feat: wait for pending navigation to resolve before many actions ( #32899 )
...
This includes all actions that perform locator handler check.
Note this makes it impossible to interact with the page while a main
frame navigation is ongoing. This was already the case for Chromium, but
now WebKit and Firefox align with it.
Setting `PLAYWRIGHT_SKIP_NAVIGATION_CHECK` environment variable disables
this behavior.
2024-10-04 07:25:18 -07:00
Simon Knott
1b457b1ff8
fix(html reporter): render annotation newlines ( #32948 )
...
Closes https://github.com/microsoft/playwright/issues/32925 . Before this
change, newlines in annotation descriptions weren't respected. This
change makes them shown. Here's how it looks for this annotation:
```ts
test.info().annotations.push({
type: 'user story',
description: '\n- user goes to the page\n- user clicks the button\n- user sees the result',
});
```
Before:
<img width="1071" alt="Screenshot 2024-10-04 at 09 55 15"
src="https://github.com/user-attachments/assets/89e74ff5-ea83-48da-a33b-833423916d95 ">
After:
<img width="1031" alt="Screenshot 2024-10-04 at 09 51 08"
src="https://github.com/user-attachments/assets/0f2914e8-bd88-4970-aa68-6a5a9828295c ">
2024-10-04 14:18:38 +02:00
Simon Knott
ff0c498904
fix(ct-vue): update default slot should work ( #32952 )
...
Closes https://github.com/microsoft/playwright/issues/32809
We were writing onto the wrong object.
2024-10-04 14:18:21 +02:00
Dmitry Gozman
10d6812058
chore: clear pendingDocument() for the same-document navigation ( #32954 )
...
WebKit notifies about a pending same-document navigation through
`Page.frameScheduledNavigation`, and committing it should clear the
`pendingDocument()`.
Extracted from #32899 .
2024-10-04 04:54:56 -07:00
Playwright Service
0a45549533
feat(chromium): roll to r1140 ( #32949 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-04 11:14:08 +02:00
Dmitry Gozman
6b1d0361cd
fix(chromium): reset mouse position upon page reuse ( #32944 )
...
Similarly to Firefox, move the mouse to (-1, -1) upon page reuse. This
fixes the corresponding test on all platforms.
2024-10-03 08:09:00 -07:00
Playwright Service
076a6e84a1
feat(chromium-tip-of-tree): roll to r1266 ( #32942 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-03 16:03:30 +02:00
Dmitry Gozman
0ffac886e8
test: fix android tests ( #32932 )
...
One test is removed, since it's impossible to fix. Hopefully, the rest
will pass.
2024-10-03 03:37:43 -07:00
Dmitry Gozman
3c5967d4f5
fix(trace viewer): clear old highlighted elements upon change ( #32917 )
...
When the list of highlighted elements changes over time, we should
update the elements marked as `__playwright_target__` in the snapshot.
A good example is an `expect(locator).toHaveText([...])` where the list
of elements changes from 4 items to 3 after clicking a "Delete" button.
2024-10-02 23:48:26 -07:00
Playwright Service
616425a0fb
feat(firefox): roll to r1465 ( #32938 )
2024-10-03 08:25:44 +02:00
Simon Knott
3a5bf1cc1d
fix(trace viewer): reveal stack for highlighted action ( #32919 )
...
Closes https://github.com/microsoft/playwright/issues/32915 .
In the `Call` and `Logs` tabs, we update the contents based on the
hovered action. We document that this is also the case for the `Source`
tab:
78054a7652/docs/src/test-ui-mode-js.md
2024-10-02 13:30:44 +02:00
Simon Knott
208a54529d
fix(ct-react): support shorthand fragment notation ( #32900 )
...
Closes https://github.com/microsoft/playwright/issues/32853
Vite turns the shorthand fragment notation `<></>` into `import {
Fragment } from "react"; <Fragment></Fragment>`. On the Node.js side of
things, this `react` import resolves to our mock version of React, which
currently mocks `Fragment` as `{}`. Currently, we pass that straight to
`React.createElement`, which throws an error.
The fix is to make our `Fragment` mock detectable with a tag, and when
we render it replace it with the real `__pwReact.Fragment`.
2024-10-02 11:19:09 +02:00
Playwright Service
0fd9452127
feat(webkit): roll to r2084 ( #32912 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-02 09:02:32 +02:00
Dmitry Gozman
773202867d
feat(trace): highlight strict mode violation elements in the snapshot ( #32893 )
...
This is fixing a case where the test failed with strict mode violation,
but all the matched elements are not highlighted in the trace.
For example, all the buttons will be highlighted when the following line
fails due to strict mode violation:
```ts
await page.locator('button').click();
```
To achieve this, we mark elements during `querySelector` phase instead
of inside `onBeforeInputAction`. This allows us to only mark from inside
the `InjectedScript` and remove the other way of marking from inside the
`Snapshotter`.
2024-10-02 00:00:45 -07:00
Max Schmitt
daac0ddd24
fix(fetch): fallback to given URL if baseURL is invalid ( #32911 )
2024-10-01 22:43:32 +02:00
Max Schmitt
78054a7652
chore: remove 'screenshot instead of snapshot' usages ( #32905 )
...
Fixes https://github.com/microsoft/playwright/issues/32904
2024-10-01 18:38:10 +02:00
Playwright Service
00e1a99d65
feat(chromium): roll to r1139 ( #32906 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-01 18:18:45 +02:00
Playwright Service
8688af0580
feat(chromium-tip-of-tree): roll to r1265 ( #32894 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-01 16:02:21 +02:00
Playwright Service
60db16bad3
feat(chromium): roll to r1138 ( #32898 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-01 15:15:00 +02:00
Max Schmitt
6f16b6cc08
chore: unflake 'should record' ( #32880 )
2024-09-30 20:32:04 +02:00
Dmitry Gozman
541ce9f0bb
chore: mark 1.49.0-next ( #32873 )
2024-09-30 04:24:57 -07:00
Simon Knott
aa3146785f
fix(ui): turn "copy as fetch" into text button ( #32858 )
...
Turns the "copy as fetch" text with a copy button into a text button, as
discussed in the meeting.
https://github.com/user-attachments/assets/01f72f0b-e3f2-440e-a75d-33385aabeec4
2024-09-30 03:01:56 -07:00
Pavel Feldman
11014145ce
chore: update trace event on action merge ( #32860 )
2024-09-27 21:18:30 -07:00
Pavel Feldman
908b0de5d4
chore: style action list in tv mode ( #32845 )
2024-09-27 17:52:03 -07:00
Max Schmitt
6721cc1746
chore: disable LensOverlay in Chromium ( #32790 )
2024-09-27 20:06:27 +02:00
Dmitry Gozman
a395fb22c4
feat(routeWebSocket): address api review feedback ( #32850 )
2024-09-27 04:01:31 -07:00
Playwright Service
d6f584c2d4
feat(chromium-tip-of-tree): roll to r1264 ( #32840 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-09-27 10:06:45 +02:00
Pavel Feldman
bcb6860ef5
chore: fix cross browser leak tests ( #32843 )
2024-09-26 19:33:07 -07:00
Pavel Feldman
1a3d3f699b
chore: render recorded action list in tv mode ( #32841 )
2024-09-26 16:46:27 -07:00
Yury Semikhatsky
5b85c71722
fix(junit): env variable should take precedence over config ( #32842 )
...
Fixes https://github.com/microsoft/playwright/issues/32826
2024-09-26 15:29:09 -07:00
Pavel Feldman
c105de4436
chore: move actions types to recorder ( #32839 )
2024-09-26 14:50:09 -07:00
Max Schmitt
0d79291604
chore: hide screenshot instead of snapshot Trace Viewer feature ( #32832 )
2024-09-26 22:30:41 +02:00
Playwright Service
463bd55cf0
feat(webkit): roll to r2083 ( #32813 )
2024-09-26 21:49:02 +02:00
Pavel Feldman
9bff4d7eab
chore: move sw files into the sw/ folder ( #32837 )
2024-09-26 11:22:20 -07:00
Yury Semikhatsky
e8d08e8d1e
docs: more prominent note on tags being read-only ( #32836 )
...
Reference https://github.com/microsoft/playwright/issues/32828
2024-09-26 09:41:38 -07:00
Dmitry Gozman
d07f6cfc5c
docs: check that description has an empty line before it ( #32830 )
2024-09-26 06:31:42 -07:00
Max Schmitt
3b86a9c0e4
docs(markdown): parse :::note's text as children ( #32510 )
2024-09-26 15:16:26 +02:00
Dmitry Gozman
a2bdb2fd79
docs: linkify params and options ( #32823 )
...
References https://github.com/microsoft/playwright/issues/32590 .
2024-09-26 05:13:00 -07:00
Dmitry Gozman
a9d5c39d40
chore: address api review for page.forceGarbageCollection ( #32824 )
...
- Renamed to `page.requestGC`.
- Added a useful snippet to the docs.
References #32278 .
---------
Signed-off-by: Dmitry Gozman <dgozman@gmail.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
2024-09-26 05:08:33 -07:00
Playwright Service
6c20318e5c
feat(chromium): roll to r1137 ( #32827 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-09-26 13:58:55 +02:00
Dmitry Gozman
ff954b58eb
fix(test runner): cleanup DEBUG_COLORS usage ( #32764 )
...
`DEBUG_COLORS` we default to `1`, but we should not do that when it is
already defined to some value supplied by the user.
Closes #32543 .
2024-09-26 03:15:46 -07:00
Dmitry Gozman
e5433d0576
chore(docs): validate params/options links ( #32820 )
...
Also supports fully-qualified links like this:
```
[`option: BrowserType.launch.headless`]
```
References https://github.com/microsoft/playwright/issues/32590 .
2024-09-26 01:08:16 -07:00
Yury Semikhatsky
597642d269
chore: pass cli config overrides straight to test server ( #32818 )
2024-09-25 19:45:59 -07:00
Pavel Feldman
61801aa1ee
chore: more codegen fixes ( #32816 )
2024-09-25 18:18:36 -07:00
Yury Semikhatsky
0480bd0cac
chore(bidi): launch firefox with user prefs tailored for testing ( #32817 )
...
Various settings that make Firefox behave when testing over Bidi. The
settings are copied from
ea36b7b1f0/packages/browsers/src/browser-data/firefox.ts (L190-L402)
2024-09-25 18:17:07 -07:00
Yury Semikhatsky
b6783bb18b
fix(ui-mode): respect --tsconfig option ( #32798 )
...
Fixes https://github.com/microsoft/playwright/issues/32797
2024-09-24 19:59:15 -07:00
Pavel Feldman
35158feec0
chore: fix codegen flakiness ( #32799 )
2024-09-24 19:56:31 -07:00
Pavel Feldman
755edfba5b
chore: fallback expect.extend to legacy ( #32795 )
2024-09-24 14:00:13 -07:00
Playwright Service
a4cea0c208
feat(webkit): roll to r2082 ( #32793 )
2024-09-24 19:46:12 +02:00
Playwright Service
0b69b1370a
feat(chromium-tip-of-tree): roll to r1263 ( #32791 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-09-24 14:44:27 +02:00
Pavel Feldman
8649b13f25
chore: start putting tv-recorder ui together ( #32776 )
2024-09-23 19:13:45 -07:00
Playwright Service
7c3dd70bf6
feat(webkit): roll to r2081 ( #32738 )
2024-09-23 19:08:01 -07:00
Yury Semikhatsky
eda0e01167
chore(bidi): bring to front, pdf ( #32698 )
2024-09-23 19:05:55 -07:00
Pavel Feldman
c7a5278fb3
fix: do not start tracing in default recorder ( #32770 )
2024-09-23 15:51:27 -07:00
Pavel Feldman
0c8b2a7c32
chore: take snapshot tab apart ( #32756 )
2024-09-23 15:51:15 -07:00
Yury Semikhatsky
11320d34c6
Revert chore: ignore third-party execution contexts ( #32437 ) ( #32771 )
...
Partially revert #32437 and add a test that console.log() messages from
content scripts are properly reported
Fixes https://github.com/microsoft/playwright/issues/32762
2024-09-23 15:48:11 -07:00
Yury Semikhatsky
c9a26e60f5
fix(webkit): 204 response is not a failure ( #32768 )
...
The login being changed was added in
https://github.com/microsoft/playwright/pull/1260 and is supposed to
only work for navigation requests.
Reference: https://github.com/microsoft/playwright/issues/32752
2024-09-23 14:30:40 -07:00
Mathias Leppich
281eff1209
docs(trial): note that modifier keys are pressed regardless of trial option ( #32734 )
2024-09-23 22:17:47 +02:00
Pavel Feldman
0cdc7ee1a3
chore: extract polling recorder ( #32749 )
...
We are reusing recorder in a snapshot tab, no need for the polling
harness to be there.
2024-09-23 08:42:18 -07:00
Playwright Service
99895005e2
feat(chromium-tip-of-tree): roll to r1262 ( #32760 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-09-23 14:47:44 +02:00
Max Schmitt
12ecd476dd
fix(watch): cancel waitForCommand when files change ( #32761 )
...
Fixes https://github.com/microsoft/playwright/issues/32758
2024-09-23 14:43:28 +02:00
Dmitry Gozman
b3a82bef46
feat: do not record route calls in the trace ( #32723 )
...
These are represented in the network pane instead.
2024-09-21 10:17:59 -07:00
Pavel Feldman
17ed944a84
chore: iterate towards recording into trace (4) ( #32743 )
2024-09-20 16:56:05 -07:00
Pavel Feldman
418d1c0c55
chore: allow starting recorder in traceviewer ( #32741 )
2024-09-20 15:25:49 -07:00
Pavel Feldman
dfb3fdf217
chore: iterate towards recording into trace (3) ( #32718 )
2024-09-20 13:08:33 -07:00
Playwright Service
33890eb6c5
feat(webkit): roll to r2080 ( #32721 )
...
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
2024-09-20 08:28:46 -07:00
Dmitry Gozman
cdcaa7fab6
feat: routeWebSocket ( #32675 )
...
This introduces `WebSocketRoute` class and
`page/context.routeWebSocket()` methods.
2024-09-20 03:20:06 -07:00
Dmitry Gozman
ace8cb2427
fix(test runner): page.pause() should enable debug mode ( #32714 )
...
Fixes #32706 .
2024-09-20 00:41:16 -07:00
Playwright Service
935aa6b020
feat(webkit): roll to r2079 ( #32720 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-09-20 09:34:31 +02:00
Pavel Feldman
01b44ba077
chore: remove PWTEST_RECORDER_PORT as it was ignored ( #32717 )
2024-09-19 13:35:52 -07:00
Max Schmitt
2b2a57abad
chore: enable @babel/plugin-syntax-import-attributes all the time ( #32713 )
2024-09-19 16:51:35 +02:00
Dmitry Gozman
cc302fa515
fix(chromium): allow PlzDedicatedWorker ( #32711 )
...
With the recent Chromium fixes in v129, it is now safe to enable this
feature.
Fixes #31747 .
2024-09-19 06:38:58 -07:00
Playwright Service
ea284f2986
feat(chromium-tip-of-tree): roll to r1261 ( #32709 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-09-19 14:47:03 +02:00
Playwright Service
e8e72deac2
feat(chromium): roll to r1136 ( #32707 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-09-19 14:35:48 +02:00
Dmitry Gozman
5089d9f293
fix(chromium): disable ThirdPartyStoragePartitioning ( #32701 )
...
See
https://developers.google.com/privacy-sandbox/cookies/storage-partitioning
for more details.
References #32230 .
2024-09-19 03:12:21 -07:00
